Publish to external VCD ORG and subscribe attributes on OrgGeneralSettings struct #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2022 16:07
…alSettings` struct Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius and
vbauzys
as code owners
lvirbalas
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Assuming the ordering of XML fields in types.go is correct, LGTM! :)
For reference (just as a note):
#436 (comment)
Didainius
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to fulfill the issue from the Terraform provider for VCD vmware/terraform-provider-vcd#775 we needed to add a couple of attributes to
OrgGeneralSettings. These areCanPublishExternallyandCanSubscribe.Detailed description
The current go-vcd SDK lacks of functionality for reading and changing some ORG values regarding catalogs. At the moment it is possible to read and change the option "Share catalogs to other organizations" through the attribute ´AdminOrg.OrgSettings.OrgGeneralSettings.CanPublishCatalogs´ but for options "Publish external catalogs" and "Subscribe to external catalogs" is not possible.
This PR adds support for both options through the attributes
CanPublishExternallyandCanSubscribefromOrgGeneralSettingsstruct.